Trac Powered

Ticket #575 (closed bug: fixed)

Opened 9 months ago

Last modified 8 months ago

Missing character "ň" in hits (column referrers)

Reported by: neoen Owned by: omry
Priority: Normal Milestone: 1.5
Component: FireStats Version: 1.4
Severity: Normal Keywords:
Cc:

Description

Hello, I have 1.4.4. (with WP 2.3.2). On my Firestats page there is missing character "ň" (Czech character) or its html entity in hits review (column referrers).

I will add screenshot.

There is http://search.seznam.cz/?q=daový rezident v ČR&mod=f.

There should be http://search.seznam.cz/?q=daňový rezident v ČR&mod=f (or entity of character "ň").

Thank you...

Attachments

Missing character.PNG (8.8 kB) - added by neoen 9 months ago.
Empty line.PNG (10.8 kB) - added by neoen 9 months ago.

Change History

Changed 9 months ago by neoen

attachment Missing character.PNG added

Changed 9 months ago by neoen

Sometimes, there are also free lines in referrers column, see following screenshot (Free line.png) with red box. It is not connected with character "ň".

Changed 9 months ago by neoen

attachment Empty line.PNG added

Changed 9 months ago by omry

Please compare this the function fs_prepare_string in line 543 at php/html-utils.php you are using with this one.

Changed 9 months ago by neoen

Yes, it is the same. I upgraded with automatic installer on November 24th and in Trac there is last change 3 month ago, so it should be the same version.

My version:

function fs_prepare_string($text, $break_at = null, $newline = "<br/>", $max_length = null)

Changed 9 months ago by omry

and the function body is the same?

Changed 9 months ago by neoen

Yes, I guess:

function fs_prepare_string($text, $break_at = null, $newline = "<br/>", $max_length = null)
{
        $text = urldecode($text);

        $break = $break_at != null;
        if ($break)
        {
                // since encode will encode our line breaks if we insert it now
                // we are doing a little trick here:
                // first put a place holder for the line break
                $text = wordwrap($text, $break_at,"{_SEP_}",1);
        }

        if ($max_length != null)
        {
                if (strlen($text) > $max_length)
                {
                        $text = substr($text,0, $max_length);
                        $text .= "...";
                }
        }

        // fix up any magic characters in the url.
        $text = str_replace (array ( '<', '>'),array ( '&lt;' , '&gt;'),$text);
        if ($break)
        {
                // now we can replace the \255 by a line break.
                $text = str_replace(array("{_SEP_}"),array($newline),$text);
        }
        return $text;
}

Changed 9 months ago by omry

okay. I will try to reproduce it when I get some time.

Changed 9 months ago by omry

milestone set to 1.5

Changed 8 months ago by omry

status changed from new to closed resolution set to fixed

fixed for 1.5

Add/Change #575 (Missing character "ň" in hits (column referrers))

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.


You are viewing a mobilized version of this site...
View original page here

Mobilized by Mowser Mowser